#1676 | FileFlows

Support

Tickets

Board

#1676:Audio Plugin: Convert Audio adaptive aac_he_v2

reven opened this ticket9 months ago

revencommented 9 months ago

Audio Plugin: Convert Audio adaptive aac_he_v2 if up to and including 2 channels, use aac_he_v2 else use aac_he

revencommented 9 months ago

fixed

kdog0598commented 8 months ago

Mine is still doing aac_he_v2 on 5.1 tracks with newest updates. I found something in "FileFlowsPlugins/AudioNodes/Nodes/ConvertFlowElements/ConvertNode.cs" that looks like it could be the issue.

Line 128-140

else if (bitrate != 0)
            {
                ffArgs.AddRange(new []
                {
                    "-ab",
                    (bitrate == -1 ? GetSourceBitrate(args).ToString() : bitrate + "k")
                });
                if (Codec == "aac" && HighEfficiency)
                {
                    extension = "m4a";
                    ffArgs.AddRange(new[] { "-profile:a", "aac_he_v2" });
                }
            }

If I'm reading the code right, this happens if bitrate is not between 10-20, which then only sets v2 with no logic in place to do v1.

revencommented 8 months ago

youre right, fixed in next version

kdog0598commented 8 months ago

It's still doing that on my convert audio flow if I have channels set to "Same as source". It is working correctly if I manually set them

fileflows version 24.07.5.3429, audio plugin version 24.07.5.948

2024-07-30 22:54:22.280 [INFO] -> ======================================================================
2024-07-30 22:54:22.281 [INFO] -> Executing Flow Element 11: ConvertAudio [FileFlows.AudioNodes.ConvertAudio]
2024-07-30 22:54:22.281 [INFO] -> ======================================================================
2024-07-30 22:54:22.281 [INFO] -> Working File: /app/tv/test/media.mkv
2024-07-30 22:54:22.281 [INFO] -> 92e93da1-2c06-49f7-a589-a74a748069de.Bitrate => Type Is: System.Double
2024-07-30 22:54:22.281 [INFO] -> ToolPathVariable 'FFMpeg' = '/app/bin/bin/ffmpeg'
2024-07-30 22:54:22.281 [INFO] -> Tool 'FFMpeg' variable = '/app/bin/bin/ffmpeg
2024-07-30 22:54:22.283 [INFO] -> ToolPathVariable 'FFMpeg' = '/app/bin/bin/ffmpeg'
2024-07-30 22:54:22.283 [INFO] -> Tool 'FFMpeg' variable = '/app/bin/bin/ffmpeg
2024-07-30 22:54:22.283 [INFO] -> ToolPathVariable 'FFprobe' = '/app/bin/bin/ffprobe'
2024-07-30 22:54:22.283 [INFO] -> Tool 'FFprobe' variable = '/app/bin/bin/ffprobe
2024-07-30 22:54:22.285 [INFO] -> ToolPathVariable 'aac_codec' = 'libfdk_aac'
2024-07-30 22:54:22.285 [INFO] -> Tool 'aac_codec' variable = 'libfdk_aac
2024-07-30 22:54:22.294 [INFO] -> FFArgs: -hide_banner -y -i /app/tv/test/media.mkv -vn -c:a libfdk_aac -ab 192k -profile:a aac_he_v2 -metadata TITLE=media -metadata ARTIST=tv -metadata ALBUM=test -metadata TRACK=1 -metadata "comment=Created by FileFlows
https://fileflows.com" /temp/Runner-fdc9ecbc-65a2-4b25-bf91-f1911f395bf8/6f152c1e-3476-4df3-bbc3-6824e952e7dd.mp4
2024-07-30 22:54:22.299 [INFO] -> ----------------------------------------------------------------------
2024-07-30 22:54:22.299 [INFO] -> Executing: /app/bin/bin/ffmpeg -hide_banner -y -i /app/tv/test/media.mkv -vn -c:a libfdk_aac -ab 192k -profile:a aac_he_v2 -metadata TITLE=media -metadata ARTIST=tv -metadata ALBUM=test -metadata TRACK=1 -metadata "comment=Created by FileFlows
https://fileflows.com" /temp/Runner-fdc9ecbc-65a2-4b25-bf91-f1911f395bf8/6f152c1e-3476-4df3-bbc3-6824e952e7dd.mp4
2024-07-30 22:54:22.299 [INFO] -> ----------------------------------------------------------------------
2024-07-30 22:54:22.315 [INFO] -> Input #0, matroska,webm, from '/app/tv/test/media.mkv':
2024-07-30 22:54:22.316 [INFO] ->   Metadata:
2024-07-30 22:54:22.316 [INFO] ->     title           : media
2024-07-30 22:54:22.316 [INFO] ->     COLLECTION/ARTIST: tv
2024-07-30 22:54:22.316 [INFO] ->     COLLECTION/TITLE: test
2024-07-30 22:54:22.316 [INFO] ->     ENCODER         : Lavf61.1.100
2024-07-30 22:54:22.316 [INFO] ->     track           : 01
2024-07-30 22:54:22.316 [INFO] ->   Duration: 00:41:35.07, start: 0.000000, bitrate: 3278 kb/s
2024-07-30 22:54:22.316 [INFO] ->   Chapters:
2024-07-30 22:54:22.316 [INFO] ->     Chapter #0:0: start 0.000000, end 519.059000
2024-07-30 22:54:22.316 [INFO] ->       Metadata:
2024-07-30 22:54:22.317 [INFO] ->         title           : Chapter 1
2024-07-30 22:54:22.317 [INFO] ->     Chapter #0:1: start 519.059000, end 812.854000
2024-07-30 22:54:22.317 [INFO] ->       Metadata:
2024-07-30 22:54:22.317 [INFO] ->         title           : Chapter 2
2024-07-30 22:54:22.317 [INFO] ->     Chapter #0:2: start 812.854000, end 1256.297000
2024-07-30 22:54:22.317 [INFO] ->       Metadata:
2024-07-30 22:54:22.317 [INFO] ->         title           : Chapter 3
2024-07-30 22:54:22.317 [INFO] ->     Chapter #0:3: start 1256.297000, end 1642.182000
2024-07-30 22:54:22.317 [INFO] ->       Metadata:
2024-07-30 22:54:22.317 [INFO] ->         title           : Chapter 4
2024-07-30 22:54:22.317 [INFO] ->     Chapter #0:4: start 1642.182000, end 2069.109000
2024-07-30 22:54:22.317 [INFO] ->       Metadata:
2024-07-30 22:54:22.318 [INFO] ->         title           : Chapter 5
2024-07-30 22:54:22.318 [INFO] ->     Chapter #0:5: start 2069.109000, end 2495.072000
2024-07-30 22:54:22.318 [INFO] ->       Metadata:
2024-07-30 22:54:22.318 [INFO] ->         title           : Chapter 6
2024-07-30 22:54:22.318 [INFO] ->   Stream #0:0: Video: hevc (Main 10), yuv420p10le(tv, bt709), 1920x1080 [SAR 1:1 DAR 16:9], 23.98 fps, 23.98 tbr, 1k tbn (default)
2024-07-30 22:54:22.318 [INFO] ->       Metadata:
2024-07-30 22:54:22.318 [INFO] ->         BPS             : 2827122
2024-07-30 22:54:22.318 [INFO] ->         BPS-en          : 2827122
2024-07-30 22:54:22.318 [INFO] ->         DURATION-en     : 00:41:34.492000000
2024-07-30 22:54:22.318 [INFO] ->         DURATION        : 00:41:34.491000000
2024-07-30 22:54:22.319 [INFO] ->         NUMBER_OF_FRAMES: 59808
2024-07-30 22:54:22.319 [INFO] ->         NUMBER_OF_FRAMES-en: 59808
2024-07-30 22:54:22.319 [INFO] ->         NUMBER_OF_BYTES : 881529460
2024-07-30 22:54:22.319 [INFO] ->         NUMBER_OF_BYTES-en: 881529460
2024-07-30 22:54:22.319 [INFO] ->         _STATISTICS_WRITING_APP: DVDFab 10.0.9.2
2024-07-30 22:54:22.319 [INFO] ->         _STATISTICS_WRITING_APP-en: DVDFab 10.0.9.2
2024-07-30 22:54:22.319 [INFO] ->         _STATISTICS_WRITING_DATE_UTC: 2018-09-25 16:16:55
2024-07-30 22:54:22.319 [INFO] ->         _STATISTICS_WRITING_DATE_UTC-en: 2018-09-25 16:16:55
2024-07-30 22:54:22.319 [INFO] ->         _STATISTICS_TAGS: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES
2024-07-30 22:54:22.319 [INFO] ->         _STATISTICS_TAGS-en: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES
2024-07-30 22:54:22.319 [INFO] ->   Stream #0:1(eng): Audio: ac3, 48000 Hz, 5.1(side), fltp, 448 kb/s (default)
2024-07-30 22:54:22.320 [INFO] ->       Metadata:
2024-07-30 22:54:22.320 [INFO] ->         BPS             : 448000
2024-07-30 22:54:22.320 [INFO] ->         BPS-en          : 448000
2024-07-30 22:54:22.320 [INFO] ->         DURATION-en     : 00:41:35.072000000
2024-07-30 22:54:22.320 [INFO] ->         DURATION        : 00:41:35.072000000
2024-07-30 22:54:22.320 [INFO] ->         NUMBER_OF_FRAMES: 77971
2024-07-30 22:54:22.320 [INFO] ->         NUMBER_OF_FRAMES-en: 77971
2024-07-30 22:54:22.320 [INFO] ->         NUMBER_OF_BYTES : 139724032
2024-07-30 22:54:22.320 [INFO] ->         NUMBER_OF_BYTES-en: 139724032
2024-07-30 22:54:22.320 [INFO] ->         _STATISTICS_WRITING_APP: DVDFab 10.0.9.2
2024-07-30 22:54:22.320 [INFO] ->         _STATISTICS_WRITING_APP-en: DVDFab 10.0.9.2
2024-07-30 22:54:22.320 [INFO] ->         _STATISTICS_WRITING_DATE_UTC: 2018-09-25 16:16:55
2024-07-30 22:54:22.321 [INFO] ->         _STATISTICS_WRITING_DATE_UTC-en: 2018-09-25 16:16:55
2024-07-30 22:54:22.321 [INFO] ->         _STATISTICS_TAGS: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES
2024-07-30 22:54:22.321 [INFO] ->         _STATISTICS_TAGS-en: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES
2024-07-30 22:54:22.321 [INFO] ->   Stream #0:2: Subtitle: subrip (srt)
2024-07-30 22:54:22.321 [INFO] ->       Metadata:
2024-07-30 22:54:22.321 [INFO] ->         DURATION        : 00:41:06.640000000
2024-07-30 22:54:22.321 [INFO] -> Stream mapping:
2024-07-30 22:54:22.321 [INFO] ->   Stream #0:1 -> #0:0 (ac3 (native) -> aac (libfdk_aac))
2024-07-30 22:54:22.321 [INFO] -> Press [q] to stop, [?] for help
2024-07-30 22:54:22.325 [INFO] -> [libfdk_aac @ 0x5641de138a80] Unable to initialize the encoder: Invalid config
2024-07-30 22:54:22.325 [INFO] -> [aost#0:0/libfdk_aac @ 0x5641de185740] Error while opening encoder - maybe incorrect parameters such as bit_rate, rate, width or height.
2024-07-30 22:54:22.325 [INFO] -> [af#0:0 @ 0x5641de180cc0] Error sending frames to consumers: Invalid argument
2024-07-30 22:54:22.327 [INFO] -> [af#0:0 @ 0x5641de180cc0] Task finished with error code: -22 (Invalid argument)
2024-07-30 22:54:22.327 [INFO] -> [af#0:0 @ 0x5641de180cc0] Terminating thread with return code -22 (Invalid argument)
2024-07-30 22:54:22.327 [INFO] -> [aost#0:0/libfdk_aac @ 0x5641de185740] Could not open encoder before EOF
2024-07-30 22:54:22.327 [INFO] -> [aost#0:0/libfdk_aac @ 0x5641de185740] Task finished with error code: -22 (Invalid argument)
2024-07-30 22:54:22.327 [INFO] -> [aost#0:0/libfdk_aac @ 0x5641de185740] Terminating thread with return code -22 (Invalid argument)
2024-07-30 22:54:22.818 [INFO] -> [out#0/mp4 @ 0x5641de17eac0] Nothing was written into output file, because at least one of its streams received no packets.
2024-07-30 22:54:22.819 [INFO] -> size=       0KiB time=N/A bitrate=N/A speed=N/A    
2024-07-30 22:54:22.819 [INFO] -> Conversion failed!
2024-07-30 22:54:22.825 [ERRR] -> Invalid exit code detected: 234
2024-07-30 22:54:22.825 [INFO] -> Flow Element execution time: 00:00:00.5446709
2024-07-30 22:54:22.827 [INFO] -> Flow Element output: -1
2024-07-30 22:54:22.827 [INFO] -> ======================================================================